feat: add increment and add operations to NumberSignal #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2694 +/- ##
==========================================
+ Coverage 92.10% 92.15% +0.04%
==========================================
Files 79 80 +1
Lines 2521 2536 +15
Branches 652 656 +4
==========================================
+ Hits 2322 2337 +15
Misses 152 152
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
platosha
approved these changes
Sep 3, 2024
|
This ticket/PR has been released with Hilla 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
taefi
added a commit
that referenced
this pull request
Sep 5, 2024
This will introduce increment event for NumberSignal so that it is processed atomically on server based on the last seen value of NumberSignal without any retries. Also, this refactors the increment method to incrementBy, and also removes the add methods that were introduced in #2694
platosha
added a commit
that referenced
this pull request
Sep 11, 2024
* fix: adjust increment api and remove add from NumberSignal.ts This will introduce increment event for NumberSignal so that it is processed atomically on server based on the last seen value of NumberSignal without any retries. Also, this refactors the increment method to incrementBy, and also removes the add methods that were introduced in #2694 * remove unnecessary imports and chai-like usage * formatter:format * set the value locally when incrementBy is called * address sonar warnings --------- Co-authored-by: Anton Platonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2622
Type of change
Checklist
Additional for
Featuretype of change