fix(TypeScript): npm peer dependency install conflicts in user applications #2699
Conversation
…ations As pointed out in npm/cli#7719, npm struggles with resolving peer dependencies when running `npm install` and applying new peer dependency requirements that do not align with previously installed versions. In many cases it produces an unexpected error for the user instead of updating installed peer dependency packages. As a (temporary?) workaround, let us avoid using strict peer dependency requirements for our packages. This changes the `package.json` to use regular dependency version spec even though the expectation is that the install is “flat”, i. e., the packages are is installed on the top-level of `node_modules/` in the user application.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2699 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 80 80
Lines 2536 2536
Branches 656 656
=======================================
Hits 2337 2337
Misses 152 152
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @platosha and @Artur-, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
As pointed out in npm/cli#7719, npm struggles with resolving peer dependencies when running
npm installand applying new peer dependency requirements that do not align with previously installed versions. In many cases it produces an unexpected error for the user instead of updating installed peer dependency packages.As a (temporary?) workaround, let us avoid using strict peer dependency requirements for our packages.
This changes the
package.jsonto use regular dependency version spec even though the expectation is that the install is “flat”, i. e., the packages are is installed on the top-level ofnode_modules/in the user application.