Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: keep vite version in sync with flow 24.5 #2744

Merged
merged 2 commits into from
Sep 23, 2024
Merged

chore: keep vite version in sync with flow 24.5 #2744

merged 2 commits into from
Sep 23, 2024

Conversation

ZheSun88
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (7f11dfc) to head (a1191b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2744   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files          81       81           
  Lines        2648     2648           
  Branches      666      666           
=======================================
  Hits         2502     2502           
  Misses        142      142           
  Partials        4        4           
Flag Coverage Δ
unittests 94.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 23, 2024

@platosha platosha merged commit a897599 into main Sep 23, 2024
15 checks passed
@platosha platosha deleted the update-vite branch September 23, 2024 07:36
@vaadin-bot
Copy link
Collaborator

Hi @ZheSun88 and @platosha, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a897599
error: could not apply a897599... chore: keep vite version in sync with flow 24.5 (#2744)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants