Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@LegacyUI, @MprTheme annotations do not work with HasUrlParameter #83

Closed
TatuLund opened this issue Apr 12, 2021 · 0 comments
Closed

@LegacyUI, @MprTheme annotations do not work with HasUrlParameter #83

TatuLund opened this issue Apr 12, 2021 · 0 comments
Assignees
@caalador
Labels
bug Something isn't working Impact: Low routing Severity: Major workaround

Comments

@TatuLund
Copy link

Vaadin versions 14.5.1, 8.12.4

@LegacyUI, @MprTheme, ... annotations do not work with HasUrlParameter

Install and deploy the attached test application

Type http://localhost:8080/other/parameter in address bar and press enter.

Exception with root cause like below is thrown

Caused by: java.lang.ClassCastException: class com.vaadin.mpr.MprUI cannot be cast to class org.vaadin.mprdemo.OldUI (com.vaadin.mpr.MprUI and org.vaadin.mprdemo.OldUI are in unnamed module of loader org.eclipse.jetty.webapp.WebAppClassLoader @d80243a)
at org.vaadin.mprdemo.MyUI.(MyUI.java:55)
... 58 more

Apparently this is regression due url parameter template feature, since the error does not happen with versions before 14.5.1.

Workaround: add @LegacyUI annotation to OtherView.java

mpr-parameter-bug.zip
@pleku pleku added bug Something isn't working Impact: Low Severity: Major labels Apr 13, 2021
@caalador caalador self-assigned this Apr 22, 2021
caalador added a commit to vaadin/docs that referenced this issue Apr 27, 2021
@caalador
fix: Update how MPR annotations are given
9c866f3 
Since all other annotations should be on the
AppShellConfiguration implementation class
in v19+ also MPR should only look for the
annotations on the configuration class.

part of vaadin/multiplatform-runtime#83
@caalador caalador mentioned this issue Apr 27, 2021
Merged
mshabarov pushed a commit to vaadin/docs that referenced this issue Apr 28, 2021
@caalador
fix: Update how MPR annotations are given (#409)
38cd5a1 
Since all other annotations should be on the
AppShellConfiguration implementation class
in v19+ also MPR should only look for the
annotations on the configuration class.

part of vaadin/multiplatform-runtime#83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
bug Something isn't working Impact: Low routing Severity: Major workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pleku @caalador @TatuLund