-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added codestart #119
Conversation
Added a codestart that provides a Flow application with an example view Closes #112
To test, after building locally the extension, in a temporary directory run
The command will create a Quarkus based Vaadin application, that can be launched in dev mode with The |
...sources/__snapshots__/VaadinExtensionCodestartTest/testApplicationContents/dir-tree.snapshot
Show resolved
Hide resolved
integration-tests/codestarts/src/test/java/com/vaadin/flow/quarkus/it/CodestartTestUtils.java
Show resolved
Hide resolved
...sionCodestartTest/testApplicationContents/src_main_java_ilove_quark_us_example_MainView.java
Show resolved
Hide resolved
...snapshots__/VaadinExtensionPreReleaseCodestartTest/testApplicationContents/dir-tree.snapshot
Show resolved
Hide resolved
Co-authored-by: Peter Czuczor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Reviewed the code
- And executed the commands, build the jars, tested both production and dev mode.
After some initial confusion, both work fine for me.
Only notes:
- Errors for missing apidocs while building (exceptions above)
- readme.MD could be updated how to properly buid/run app:
- commands, paths for dev an production profiles.
Kudos, SonarCloud Quality Gate passed! |
For the notes, it may be worth creating some tickets, as they are not strictly related to the changes in this PR |
Added a codestart that provides a Flow application with an example view Closes #112 Co-authored-by: Peter Czuczor <[email protected]>
Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 1.1, i have encountered the following issue. Can you take a look and pick it manually? |
Was already picked manually |
Description
Added a codestart that provides a Flow application with an example view
Closes #112
Type of change
Checklist
Additional for
Feature
type of change