feat: support type constraints for generic types #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
commented
Aug 26, 2024
Comment on lines
-228
to
+234
| ? genericTypeNames.map(() => ts.factory.createKeywordTypeNode(ts.SyntaxKind.UnknownKeyword)) | ||
| ? genericTypeNames.map(() => ts.factory.createKeywordTypeNode(ts.SyntaxKind.AnyKeyword)) |
There was a problem hiding this comment.
Also needed to change the generic type of the Event Map passed to createComponent to any since unknown doesn't satisfy the constraint:
web-padawan
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support providing type constraints to component generic types.
This feature is required by the upcoming Dashboard component which has a constraint for the item type it is given.
You can test the feature, for example. by adding
typeConstraints: ['VirtualListDefaultItem']to "VirtualList" in the settings.ts file and then runningnpm run buildThe resulting difference in the
src/generated/VirtualList.d.tsfile:Type of change
Feature