fix(Grid): omit re-exports from GridColumn.js #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cromoteca
previously approved these changes
Apr 19, 2023
|
@cromoteca sorry, after some thought I came up with a solution not involving an explicit list here. Let me kindly ask for another review :-) |
cromoteca
reviewed
Apr 19, 2023
cromoteca
approved these changes
Apr 19, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
* fix(Grid): omit re-exports from GridColumn.js Fixes #68 * simplify specifiers * fix(Grid): avoid explicit list of types in exports
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 19, 2023
* fix(Grid): omit re-exports from GridColumn.js Fixes #68 * simplify specifiers * fix(Grid): avoid explicit list of types in exports
platosha
added a commit
that referenced
this pull request
Apr 20, 2023
fix(Grid): omit re-exports from GridColumn.js (#89) * fix(Grid): omit re-exports from GridColumn.js Fixes #68 * simplify specifiers * fix(Grid): avoid explicit list of types in exports Co-authored-by: Anton Platonov <[email protected]>
platosha
added a commit
that referenced
this pull request
Apr 20, 2023
* fix(Grid): omit re-exports from GridColumn.js Fixes #68 * simplify specifiers * fix(Grid): avoid explicit list of types in exports
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68