fix: prevent incorrect overflow in Safari #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix-safari-overflow
branch
from
0aa3df5
to
6686d77
Compare
alvarezguille
approved these changes
Jul 22, 2020
web-padawan
added a commit
that referenced
this pull request
Jul 22, 2020
web-padawan
added a commit
that referenced
this pull request
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes vaadin/vaadin-dialog-flow#204
See the description of the actual Safari issue here: vaadin/vaadin-dialog-flow#204 (comment)
The fix can be tested with the demo: vaadin/vaadin-dialog-flow@576c140
This should not re-introduce regression from #172 because
min-heightis set on the different element.