fix: clear reference to element removed from split-layout (#7367) (#7368

) Co-authored-by: Serhii Kulykov <[email protected]>
vaadin · Apr 29, 2024 · 0e54057 · 0e54057
1 parent 4af11f8
commit 0e54057
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/packages/split-layout/src/vaadin-split-layout-mixin.js b/packages/split-layout/src/vaadin-split-layout-mixin.js
@@ -56,7 +56,11 @@ export const SplitLayoutMixin = (superClass) =>
     _cleanupNodes(nodes) {
       nodes.forEach((node) => {
         if (!(node.parentElement instanceof this.constructor)) {
-          node.removeAttribute('slot');
+          const slot = node.getAttribute('slot');
+          if (slot) {
+            this[`_${slot}Child`] = null;
+            node.removeAttribute('slot');
+          }
         }
       });
     }

diff --git a/packages/split-layout/test/split-layout.common.js b/packages/split-layout/test/split-layout.common.js
@@ -421,6 +421,22 @@ describe('removing nodes', () => {
     await nextFrame();
     expect(first.hasAttribute('slot')).to.be.false;
   });
+
+  it('should not update splitter position on the removed node', async () => {
+    splitLayout.removeChild(second);
+    await nextFrame();
+    track(splitLayout.$.splitter, -10, 0);
+    expect(second.style.flex).to.be.not.ok;
+  });
+
+  it('should not dispatch `splitter-dragend` event if node is removed', async () => {
+    const spy = sinon.spy();
+    splitLayout.addEventListener('splitter-dragend', spy);
+    splitLayout.removeChild(second);
+    await nextFrame();
+    track(splitLayout.$.splitter, -10, 0);
+    expect(spy.called).to.be.false;
+  });
 });
 
 describe('moving nodes between layouts', () => {