Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license related metadata to commercial components #3773

Closed
Artur- opened this issue May 3, 2022 · 0 comments · Fixed by #3832
Closed

Add license related metadata to commercial components #3773

Artur- opened this issue May 3, 2022 · 0 comments · Fixed by #3832
Assignees

Comments

@Artur-
Copy link
Member

Artur- commented May 3, 2022

Describe your motivation

The new license checker relies on reading package.json and/or the class defining the custom element to understand which identifier should be used when validating the license when the package is using the CVDL license.

Describe the solution you'd like

For package.json it assumes that there is a cvdlName field with the license identifier for any commercial component.

For the custom element class, it needs a way to figure out the same identifier in any good way that you can come up with. It does not have to be public API it can instead be some simple pattern matching to a string constant, e.g. cvdl:<cvdlName>: or whatever else that does not occur elsewhere. Do note that the identifier can probably not be in a normal comment as that will be removed by Vite in development mode.

Describe alternatives you've considered

Additional context

@vursen vursen self-assigned this May 11, 2022
mshabarov pushed a commit to vaadin/flow that referenced this issue Jun 22, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773
vaadin-bot pushed a commit to vaadin/flow that referenced this issue Jun 22, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773
Artur- pushed a commit to vaadin/flow that referenced this issue Jun 22, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773
mshabarov pushed a commit to vaadin/flow that referenced this issue Oct 10, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773

(cherry picked from commit f8030d5)
mshabarov pushed a commit to vaadin/flow that referenced this issue Oct 18, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773

(cherry picked from commit f8030d5)
mshabarov pushed a commit to vaadin/flow that referenced this issue Oct 19, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773

(cherry picked from commit f8030d5)
caalador pushed a commit to vaadin/flow that referenced this issue Oct 20, 2022
The fallback check is no longer needed as all components have been updated.

Related-to vaadin/web-components#3773

(cherry picked from commit f8030d5)
alvarezguille added a commit to vaadin/vaadin-board that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-charts that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-confirm-dialog that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-cookie-consent that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-crud that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-grid-pro that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-rich-text-editor that referenced this issue Oct 24, 2022
web-padawan pushed a commit to vaadin/vaadin-cookie-consent that referenced this issue Oct 24, 2022
web-padawan pushed a commit to vaadin/vaadin-confirm-dialog that referenced this issue Oct 24, 2022
web-padawan pushed a commit to vaadin/vaadin-rich-text-editor that referenced this issue Oct 24, 2022
web-padawan pushed a commit to vaadin/vaadin-charts that referenced this issue Oct 24, 2022
alvarezguille added a commit to vaadin/vaadin-board that referenced this issue Oct 24, 2022
web-padawan pushed a commit to vaadin/vaadin-grid-pro that referenced this issue Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants