Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning variant for vaadin-button #5911

Closed
TatuLund opened this issue May 28, 2023 · 1 comment · Fixed by #7485
Closed

Add warning variant for vaadin-button #5911

TatuLund opened this issue May 28, 2023 · 1 comment · Fixed by #7485
Labels

Comments

@TatuLund
Copy link
Contributor

Describe your motivation

As Vaadin 24.1 has defined now Warning colors, for sake of consistency vaadin-button should have a warning variant. This kind of button is needed e.g. in dialogs which have a warning nature.

Describe the solution you'd like

I used these styles in my test app

:host([theme~='warning']) {
    background-color: var(--_lumo-button-primary-background-color, var(--lumo-warning-color));
    color: var(--_lumo-button-primary-color, var(--lumo-warning-contrast-color));
    font-weight: 600;
    min-width: calc(var(--lumo-button-size) * 2.5);
}

Describe alternatives you've considered

No response

Additional context

No response

@TatuLund TatuLund added enhancement New feature or request vaadin-button labels May 28, 2023
@TatuLund
Copy link
Contributor Author

TatuLund commented May 28, 2023

See also request for ConfirmDialog theme variants: #5912

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants