-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add warning theme variant for button #7485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add screenshot tests for this change. You can find an example here:
web-components/packages/button/test/visual/lumo/button.test.js
Lines 133 to 168 in 1cabf0c
['contrast', 'success', 'error'].forEach((variant) => { | |
describe(variant, () => { | |
it('primary', async () => { | |
element.setAttribute('theme', `primary ${variant}`); | |
await visualDiff(div, `theme-primary-${variant}`); | |
}); | |
it('secondary', async () => { | |
element.setAttribute('theme', `${variant}`); | |
await visualDiff(div, `theme-secondary-${variant}`); | |
}); | |
it('tertiary', async () => { | |
element.setAttribute('theme', `tertiary ${variant}`); | |
await visualDiff(div, `theme-tertiary-${variant}`); | |
}); | |
it('primary disabled', async () => { | |
element.setAttribute('theme', `primary ${variant}`); | |
element.disabled = true; | |
await visualDiff(div, `theme-primary-${variant}-disabled`); | |
}); | |
it('secondary disabled', async () => { | |
element.setAttribute('theme', `${variant}`); | |
element.disabled = true; | |
await visualDiff(div, `theme-secondary-${variant}-disabled`); | |
}); | |
it('tertiary disabled', async () => { | |
element.setAttribute('theme', `tertiary ${variant}`); | |
element.disabled = true; | |
await visualDiff(div, `theme-tertiary-${variant}-disabled`); | |
}); | |
}); | |
}); |
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version. |
Description
For sake of consistency, this PR adds the warning variant for vaadin-button.
Fixes #5911
Type of change
Checklist