Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High CPU usage when Grid page size is set to a large value #6648

Closed
pepijnve opened this issue Sep 17, 2024 · 3 comments
Closed

High CPU usage when Grid page size is set to a large value #6648

pepijnve opened this issue Sep 17, 2024 · 3 comments
Labels
waiting for author Further information is requested

Comments

@pepijnve
Copy link
Contributor

Description

Setting the page size of a Grid to a very large value can lead to browser side hangs even if the data provider does not contain many items.

Expected outcome

I would expect the performance of the Grid to be proportional to the actual number of items in the data provider rather than the potential number of items in a page.

Minimal reproducible example

Grid g = new Grid();
... add a data provider with a small number of items
g.setAllRowsVisible(true);
g.setPageSize(Integer.MAX_VALUE / 10);

Steps to reproduce

Add the above snippet to a view

I'm not sure what the requirement is to trigger the code path, but you want to reach line https://github.com/vaadin/flow-components/blob/main/vaadin-grid-flow-parent/vaadin-grid-flow/src/main/resources/META-INF/resources/frontend/gridConnector.ts#L513 with items being undefined.

This will cause an empty Array to be created of size pageSize which then needs to be iterated over. If pageSize is some huge value this will cause the browser event loop to hang for a while.

Environment

Vaadin version(s): 24.4.11
OS: macOS

Browsers

Issue is not browser related
pepijnve added a commit to datadobi/flow-components that referenced this issue Sep 17, 2024
@pepijnve
Avoid creating potentially large empty arrays when clearing grid cache
b4bec5b 
Fixes vaadin#6648
pepijnve added a commit to datadobi/web-components that referenced this issue Sep 17, 2024
@pepijnve
Add to allow fixing vaadin/flow-components#6648
9e52cad
This was referenced Sep 17, 2024
Closed
Closed
@vursen
Copy link
Contributor

vursen commented Sep 30, 2024 •
edited
Loading

Hello @pepijnve!

I've tried to reproduce the issue using the following snippet (based on your example):

Grid<String> grid = new Grid<>();
grid.addColumn(item -> item);
grid.setItems("Item 1", "Item 2", "Item 3");
grid.setAllRowsVisible(true);
grid.setPageSize(Integer.MAX_VALUE / 10);
add(grid);

However, this snippet doesn't trigger the mentioned code path, which you stated is necessary for reproduction:

Screen.Recording.2024-09-30.at.12.09.41.mov

As a result, the issue wasn't reproducible. Could you provide a full example?

@pepijnve
Copy link
Contributor Author

There must be something else in the data provider we're using in our app that triggers that code path then. I'll try to come up with a proper reproduction example.

@vursen vursen added the waiting for author Further information is requested label Oct 14, 2024
@vursen
Copy link
Contributor

vursen commented Nov 5, 2024

Closing due to inactivity. Feel free to reopen if it's still relevant.

@vursen vursen closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for author Further information is requested
Projects
None yet
Milestone
No milestone
2 participants
@pepijnve @vursen