Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache#clearPage to allow fixing https://github.com/vaadin/flow-components/issues/6648 #7808

Closed
wants to merge 1 commit into from

Conversation

pepijnve
Copy link
Contributor

Description

This PR adds a method to Cache that provides a more efficient way to clear a page of items than calling setPage with an Array with all undefined values.

Fixes vaadin/flow-components#6648

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/pr
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

sonarcloud bot commented Sep 17, 2024

Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I've requested more details in the ticket to help us reproduce this issue and subsequently create a test case.

@vursen
Copy link
Contributor

vursen commented Nov 5, 2024

Closing due to the lack of a reproduction example. Feel free to reopen the ticket if the issue is still relevant.

@vursen vursen closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High CPU usage when Grid page size is set to a large value
2 participants