Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not focus the field on helper element click #2232

Merged
merged 25 commits into from
Jul 19, 2021
Merged

fix: do not focus the field on helper element click #2232

merged 25 commits into from
Jul 19, 2021

Commits on Jul 7, 2021

  1. add the fix and the basic test for it

    @hdamr
    hdamr committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    f954fdb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. put a draft solution for inconsistent focus

    @hdamr
    hdamr committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    afec2e9 View commit details
    Browse the repository at this point in the history

  2. chore: fix typo

    @hdamr
    hdamr committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    a96e1a9 View commit details
    Browse the repository at this point in the history

  3. remove console log

    @hdamr
    hdamr committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    d394cc9 View commit details
    Browse the repository at this point in the history

  4. add a test case for nested helper click

    @hdamr
    hdamr committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    0638be4 View commit details
    Browse the repository at this point in the history

  5. add test case when the helper text is only text

    @hdamr
    hdamr committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    727c220 View commit details
    Browse the repository at this point in the history

  6. re arrange tests

    @hdamr
    hdamr committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    6ad7190 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. fix logic of preventing default in click handler in vaadin-text-field

    @hdamr
    hdamr committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    7b2622d View commit details
    Browse the repository at this point in the history

  2. rearrange the tests a bit.

    @hdamr
    hdamr committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    ba85728 View commit details
    Browse the repository at this point in the history

  3. fix click on slotted helper issue in vaadin-select

    @hdamr
    hdamr committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    eb0fe80 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. add test for vaadin-text-area

    @hdamr
    hdamr committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    b0858e1 View commit details
    Browse the repository at this point in the history

  2. change logic for preventDefault

    @hdamr
    hdamr committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    6f46227 View commit details
    Browse the repository at this point in the history

  3. make test more complex

    @hdamr
    hdamr committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    2fd9248 View commit details
    Browse the repository at this point in the history

  4. add fix for vaadin-custom-field

    @hdamr
    hdamr committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    f42ad54 View commit details
    Browse the repository at this point in the history

  5. add fix for vaadin-checkbox-group

    @hdamr
    hdamr committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    8f5f4dd View commit details
    Browse the repository at this point in the history

  6. skip temprary tests for checkbox group

    @hdamr
    hdamr committed Jul 12, 2021
    Configuration menu
    Copy the full SHA
    d807144 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. fix inconsistent focus behaviour by removing on-click on helper text … 

    …in various components.
    @hdamr
    hdamr committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    76da827 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. improve solution for vaadin-select

    @hdamr
    hdamr committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    ee032a6 View commit details
    Browse the repository at this point in the history

  2. change test to use sinon for testing focus.

    @hdamr
    hdamr committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    28f71e8 View commit details
    Browse the repository at this point in the history

  3. test: update assertion in the test

    @web-padawan
    web-padawan authored Jul 14, 2021
    Configuration menu
    Copy the full SHA
    4fe0201 View commit details
    Browse the repository at this point in the history

  4. chore: fix formatting

    @hdamr
    hdamr committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    f20b837 View commit details
    Browse the repository at this point in the history

  5. chore: remove unused code.

    @hdamr
    hdamr committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    5cba17b View commit details
    Browse the repository at this point in the history

  6. chore: fix formatting

    @hdamr
    hdamr committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    608d08b View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2021

  1. fix: fix test for focus on input field

    @hdamr
    hdamr committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    7d4aae1 View commit details
    Browse the repository at this point in the history

  2. fix: fix test case for testing focus on helper input

    @hdamr
    hdamr committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    9694b40 View commit details
    Browse the repository at this point in the history