feat: add type definitions for change event

[web-padawan]

Description

The main idea behind this improvement is providing a type for target property of the change event object.
This is especially important because typically inside a change event listener users check event.target.value.

We might consider updating all the other custom events to have type for target separately later.

Fixes #3040

Type of change

• Feature

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[sissbruecker]

Looks good.

We might consider updating all the other custom events to have type for target separately later.

That would have been my only concern. There is probably an opportunity to add a base event type per component, and use that for all custom events. But I'm not sure if all custom events actually have the host element set as target.

Maybe there is also a language construct where you can modify the value types of HTMLElementEventMap to override the target property 🤔

[web-padawan]

But I'm not sure if all custom events actually have the host element set as target.

Yes, technically they do. I will create a separate issue as a follow-up and we probably can do that in V23.

[vaadin-bot]

Hi @web-padawan , this commit cannot be picked to 22.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick b3be9ea
error: could not apply b3be9ea... feat: add type definitions for change event (#3085)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

[web-padawan]

We probably should not pick this to Vaadin 22 as we are about to have a release candidate today.

[vaadin-bot]

This ticket/PR has been released with platform 23.0.0.