Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: align how clear button works with combo-box behavior (#6100) (CP: 23.3) #6127

Merged
merged 1 commit into from
Jul 7, 2023
Merged

fix!: align how clear button works with combo-box behavior (#6100) (CP: 23.3) #6127

merged 1 commit into from
Jul 7, 2023

Conversation

DiegoCardoso
Copy link
Contributor

Description

CP from #6100.

I had to manually copy the changes because the clear-button-mixin was introduced after V23.

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DiegoCardoso DiegoCardoso merged commit 0e57514 into 23.3 Jul 7, 2023
@DiegoCardoso DiegoCardoso deleted the cp/pr6100-23.3 branch July 7, 2023 08:45
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.3.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-padawan web-padawan web-padawan approved these changes

@vursen vursen Awaiting requested review from vursen

Assignees
No one assigned
Labels
Released with Vaadin 23.3.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiegoCardoso @vaadin-bot @web-padawan