-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-initialize Quill on detach and re-attach and keep htmlValue #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/quill-listeners-reattach
branch
from
September 18, 2023 11:59
20d60f2
to
54b30e3
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
vursen
approved these changes
Sep 19, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…6506) Co-authored-by: sujoykd <[email protected]>
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…6506) Co-authored-by: sujoykd <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Sep 19, 2023
…6506) (#6514) Co-authored-by: Serhii Kulykov <[email protected]> Co-authored-by: sujoykd <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Sep 19, 2023
…6506) (#6513) Co-authored-by: Serhii Kulykov <[email protected]> Co-authored-by: sujoykd <[email protected]>
ghost
pushed a commit
to dethell/web-components
that referenced
this pull request
Sep 26, 2023
…aadin#6506) Co-authored-by: sujoykd <[email protected]>
This ticket/PR has been released with Vaadin 24.2.0.beta1 and is also targeting the upcoming stable 24.2.0 version. |
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6480
Same as #6489 but with a fix to flush the value debouncer in
disconnectedCallback()
.Type of change