feat: always show at least last selected item as a chip #6702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Oct 26, 2023
packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js
Outdated
Show resolved
Hide resolved
DiegoCardoso
approved these changes
Oct 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
This ticket/PR has been released with Vaadin 24.3.0.alpha3 and is also targeting the upcoming stable 24.3.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4821
Added
--vaadin-multi-select-combo-box-chip-min-widthcustom CSS property with the default value of 50px, which allows to fit one letter plus ellipsis, while also keeping enough space for the<input>element and clear button.Type of change
Before
After