Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing a11y-base dependency to side-nav #6944

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

web-padawan
Copy link
Member

Description

Trying to use @vaadin/side-nav package in a Vite app currently throws an error due to missing dependency:

✘ [ERROR] Could not resolve "@vaadin/a11y-base/src/disabled-mixin.js"

    node_modules/@vaadin/side-nav/src/vaadin-side-nav-item.js:8:30:
      8 │ import { DisabledMixin } from '@vaadin/a11y-base/src/disabled-mixin.js';
        ╵                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] Could not resolve "@vaadin/a11y-base/src/styles/sr-only-styles.js"

    node_modules/@vaadin/side-nav/src/vaadin-side-nav-item.js:9:33:
      9 │ import { screenReaderOnly } from '@vaadin/a11y-base/src/styles/sr-only-styles.js';
        ╵                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit a08d68a into main Dec 8, 2023
9 checks passed
@web-padawan web-padawan deleted the fix/side-nav-dependency branch December 8, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants