refactor!: update MSCB overlay to not extend vaadin-overlay #7002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
commented
Dec 25, 2023
| @@ -3,7 +3,6 @@ | |||
| * Copyright (c) 2021 - 2023 Vaadin Ltd. | |||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | |||
| */ | |||
| import '@vaadin/overlay/theme/lumo/vaadin-overlay.js'; | |||
There was a problem hiding this comment.
This theme import was added to overlay based components in #3888 but it's no longer needed: from now on, vaadin-overlay doesn't get defined when importing vaadin-multi-select-combo-box.
| @@ -3,7 +3,6 @@ | |||
| * Copyright (c) 2021 - 2023 Vaadin Ltd. | |||
| * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/ | |||
| */ | |||
| import '@vaadin/overlay/theme/material/vaadin-overlay.js'; | |||
There was a problem hiding this comment.
Same as above, this import it's no longer needed as the component does not define vaadin-overlay.
vursen
approved these changes
Dec 27, 2023
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #6134 but for
vaadin-multi-select-combo-box.Part of #5718
Updated
vaadin-multi-select-combo-box-overlayto align with thevaadin-combo-box-overlay.As a result, this component no longer imports
vaadin-overlayso it doesn't get defined.Type of change