feat: add readonly property to checkbox and checkbox-group #7199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/checkbox-readonly-state
branch
2 times, most recently
from
1f64d90
to
8941cdd
Compare
web-padawan
changed the title
web-padawan
force-pushed
the
feat/checkbox-readonly-state
branch
from
8941cdd
to
79464bc
Compare
rolfsmeds
requested changes
Mar 26, 2024
There was a problem hiding this comment.
- Checked box bg color (see line comment)
- Optional border set with
--vaadin-input-field-border-widthshould be suppressed in readonly (otherwise there'll be two borders on top of each other) - Unchecked label text color should deafult to
--lumo-secondary-text-color
Otherwise looks good!
Done.
Done. |
web-padawan
force-pushed
the
feat/checkbox-readonly-state
branch
from
86064ca
to
5741c7a
Compare
sissbruecker
approved these changes
Apr 2, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
web-padawan
commented
Apr 2, 2024
|
|
UPD: as agreed internally, this change is OK to include to |
|
This ticket/PR has been released with Vaadin 24.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #688
Type of change
Note
According to HTML test cases and my tests,
aria-readonlyisn't supported by VoiceOver (NVDA and JAWS work).