fix!: update vaadin-grid-selection-column to use autoWidth: true #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/selection-column-frozen-overflow
branch
from
8665a40
to
2f49372
Compare
|
Looks like the fix with |
web-padawan
changed the title
web-padawan
commented
Mar 19, 2024
web-padawan
changed the title
|
tomivirkki
approved these changes
Mar 19, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha17 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7177
The issue with
text-overflow: ellipsisis caused by the fact that hardcoded58pxwidth isn't sufficient for Lumo as soon as the selection column gets1pxborder which is applied to[last-frozen]or[first-frozen-to-end]columns.Updated to set
overflow: visiblein Lumo, and also added corresponding visual tests to both Lumo and Material.Type of change