Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: focus editor only after it is ready #7235

Merged
merged 20 commits into from
Mar 28, 2024
Merged

fix: focus editor only after it is ready #7235

merged 20 commits into from
Mar 28, 2024

Commits on Mar 27, 2024

  1. fix: defer focus in order to have editor ready before

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3abaf85 View commit details
    Browse the repository at this point in the history

  2. test: fix unit test for firefox

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    cfb7887 View commit details
    Browse the repository at this point in the history

  3. test: await next render before assertion

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b128cc2 View commit details
    Browse the repository at this point in the history

  4. test: add another await next render after the first keydown

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fe49083 View commit details
    Browse the repository at this point in the history

  5. Revert "test: add another await next render after the first keydown" 

    This reverts commit 3a62f57.
    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    727a168 View commit details
    Browse the repository at this point in the history

  6. Revert "test: await next render before assertion" 

    This reverts commit d5939d1.
    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    83081e5 View commit details
    Browse the repository at this point in the history

  7. test: update material visual test reference image

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f180f2b View commit details
    Browse the repository at this point in the history

  8. fix: set edit initiator char explicitly

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7a7ba81 View commit details
    Browse the repository at this point in the history

  9. test: revert skip test

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    80b35d7 View commit details
    Browse the repository at this point in the history

  10. fix: do not select input when initialized with character

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0df8bde View commit details
    Browse the repository at this point in the history

  11. Update packages/grid-pro/test/edit-column-type.common.js 

    Co-authored-by: Sergey Vinogradov <[email protected]>
    @ugur-vaadin @vursen
    ugur-vaadin and vursen committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1c27e3b View commit details
    Browse the repository at this point in the history

  12. refactor: extract input selection logic from editor focus

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    558ae39 View commit details
    Browse the repository at this point in the history

  13. refactor: change name of the new property

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    774cb53 View commit details
    Browse the repository at this point in the history

  14. refactor: focus lit editor once it is ready

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    750fe4e View commit details
    Browse the repository at this point in the history

  15. test: revert unnecessary awaits

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    bde29e2 View commit details
    Browse the repository at this point in the history

  16. test: revery unnecessary test assertion changes

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d82353d View commit details
    Browse the repository at this point in the history

  17. Revert "test: update material visual test reference image" 

    This reverts commit f180f2b.
    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    44c453a View commit details
    Browse the repository at this point in the history

  18. test: skip new test on firefox

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c3136e9 View commit details
    Browse the repository at this point in the history

  19. test: revert test skip change

    @ugur-vaadin
    ugur-vaadin committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    74277ad View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Update packages/grid-pro/test/edit-column-type.common.js 

    Co-authored-by: Sergey Vinogradov <[email protected]>
    @ugur-vaadin @vursen
    ugur-vaadin and vursen authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8ea9a52 View commit details
    Browse the repository at this point in the history