fix: use document scroll instead of the visual viewport #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/document-scroll
branch
from
7ba4a69
to
f6f3b69
Compare
|
web-padawan
commented
Apr 3, 2024
| this.__positionTargetAncestorRootNodes = getAncestorRootNodes(this.positionTarget).filter( | ||
| (node) => node !== document, | ||
| ); | ||
| this.__positionTargetAncestorRootNodes = getAncestorRootNodes(this.positionTarget); |
There was a problem hiding this comment.
This restores listening to scroll events on the document for desktop browsers.
tomivirkki
approved these changes
Apr 3, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 4, 2024
) (#7299) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #7279
After merging the above PR, I discovered that for some reason,
scrollevent isn't fired onwindow.visualViewporton desktop browsers, so e.g.vaadin-combo-boxoverlay doesn't reposition on scroll with that change:scroll-bug.mp4
Restored listening to
scrollevent on thedocumentin addition towindow.visualViewport(used by iOS).Type of change