Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide menu-bar tooltip on overlay mouseleave to outside #7322

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes vaadin/flow-components#5614

The issue was caused by the fact that vaadin-menu-bar uses vaadin-tooltip in manual mode, where the corresponding listener added automatically doesn't work. Fixed this by adding event listener manually and copying the corresponding logic.

Type of change

  • Bugfix

@web-padawan web-padawan force-pushed the fix/menu-bar-tooltip-hide-mouseleave branch from 7c37a2b to cd54420 Compare April 11, 2024 09:02
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan removed the request for review from tomivirkki April 12, 2024 06:39
@web-padawan web-padawan merged commit 1230085 into main Apr 12, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/menu-bar-tooltip-hide-mouseleave branch April 12, 2024 06:39
web-padawan added a commit that referenced this pull request Apr 12, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent Tooltip in MenuBar
3 participants