-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide menu-bar tooltip on overlay mouseleave to outside #7322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/menu-bar-tooltip-hide-mouseleave
branch
from
April 11, 2024 09:02
7c37a2b
to
cd54420
Compare
Quality Gate passedIssues Measures |
vursen
approved these changes
Apr 11, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
…7326) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
web-padawan
added a commit
that referenced
this pull request
Apr 12, 2024
This ticket/PR has been released with Vaadin 24.4.0.alpha22 and is also targeting the upcoming stable 24.4.0 version. |
This was referenced Jun 10, 2024
Closed
This was referenced Jun 10, 2024
Closed
Closed
This was referenced Jun 11, 2024
Closed
This was referenced Jun 12, 2024
[Snyk] Upgrade @vaadin/vaadin-lumo-styles from 23.4.0 to 23.5.1
vaadin/skeleton-starter-flow-cdi#665
Closed
Closed
This was referenced Jun 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#5614
The issue was caused by the fact that
vaadin-menu-bar
usesvaadin-tooltip
in manual mode, where the corresponding listener added automatically doesn't work. Fixed this by adding event listener manually and copying the corresponding logic.Type of change