fix: allow to set virtualizer items when not opened #7325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression from #7277
In
vaadin-combo-box
, we have a logic that clears scroller items on close:web-components/packages/combo-box/src/vaadin-combo-box-mixin.js
Lines 507 to 508 in 2efeeeb
In the PR linked above, this behavior was broken by the
items
observer change.Added a test to ensure visible items count is reset (which is a side effect of clearing items).
This seems to be the easiest way to test the change without accessing
__virtualizer
API.Type of change