fix: hide crud editor focus ring from pointer events #7339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
web-padawan
approved these changes
Apr 16, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
tomivirkki
added a commit
that referenced
this pull request
Apr 16, 2024
Co-authored-by: Tomi Virkki <[email protected]>
|
This ticket/PR has been released with Vaadin 24.4.0.alpha24 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was that the focus ring element that covers the editor was receiving pointer events so the wheel events were emitted on it instead of the underlying editor:
Kapture.2024-04-16.at.12.32.02.mp4
This PR hides the crud editor focus ring from pointer events.
Fixes #6693
Type of change
Bugfix