test: clean up notification animation tests #7341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The animation tests for
<vaadin-notifiction>
need cleaning up. In their current state, they rely on theduration
timing to close the notifications around the time the test case starts.This PR refactors the tests to use -1 for
duration
and usenotification.close()
to explicitly close the notifications when necessary. It also removes the custom CSS in favor of using inline styles.This is a prerequisite for fixing #6878
Type of change
Tests