Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect overflow correctly when used in a dialog #7347

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7338

Note: the original issue appears to be caused by the Lumo dialog animation, so I only added the integration test.

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan requested review from tomivirkki and removed request for vursen April 22, 2024 11:28
@web-padawan web-padawan merged commit 9b343a4 into main Apr 22, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/menu-bar-dialog-overflow branch April 22, 2024 11:34
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 9b343a4
error: could not apply 9b343a4... fix: detect overflow correctly when used in a dialog (#7347)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha24 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu bar not always take container paddings into account regarding overflow calculation
3 participants