-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dropdown-indicators Lumo variant to menu-bar button #7381
Conversation
...es/menu-bar/test/visual/lumo/screenshots/menu-bar/baseline/ltr-dropdown-indicators-small.png
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arrow still seems to be slightly unaligned in tertiary-inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Description
Part of #7345
Based on #7345 (comment)
Type of change
Note
Added
:not([theme='icon'])
because this was present in the original "workaround" code snippet.Combining these two variants is probably not a good idea so maybe we could drop this code.