Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing data provider tests #7425

Merged
merged 2 commits into from
May 17, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented May 17, 2024

Description

The PR adds unit tests to ensure that the combo-box adds items to the cache when the data provider returns undefined size and doesn't add items to the cache that exceed the returned size.

Related to #7044

Type of change

  • Internal

@vursen vursen marked this pull request as ready for review May 17, 2024 11:22
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@vursen vursen merged commit f9559b6 into main May 17, 2024
8 of 9 checks passed
@vursen vursen deleted the test/improve-combo-box-test-coverage-10 branch May 17, 2024 11:43
@vursen vursen removed the request for review from web-padawan May 17, 2024 11:44
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants