Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add trigger property, make opened property public #7430

Merged
merged 16 commits into from
May 22, 2024
Merged

feat: add trigger property, make opened property public #7430

merged 16 commits into from
May 22, 2024

Commits on May 20, 2024

  1. feat: add trigger property, make opened property public

    @web-padawan
    web-padawan committed May 20, 2024
    Configuration menu
    Copy the full SHA
    a20ad7b View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. feat: add hover-or-focus, only restore focus for click trigger

    @web-padawan
    web-padawan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    be39772 View commit details
    Browse the repository at this point in the history

  2. feat: add opened-changed event type definition and event map

    @web-padawan
    web-padawan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f2d03e2 View commit details
    Browse the repository at this point in the history

  3. refactor: use pseudo-element instead of closing debouncer

    @web-padawan
    web-padawan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bec6305 View commit details
    Browse the repository at this point in the history

  4. test: add missing unit tests for trigger

    @web-padawan
    web-padawan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0c9738b View commit details
    Browse the repository at this point in the history

  5. refactor: only toggle on keyboard click in case of hover-or-click

    @web-padawan
    web-padawan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9bf95f7 View commit details
    Browse the repository at this point in the history

  6. refactor: extract duplicating code into methods

    @web-padawan
    web-padawan committed May 21, 2024
    Configuration menu
    Copy the full SHA
    827ef49 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. refactor: update to use array syntax for trigger property

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cd8f324 View commit details
    Browse the repository at this point in the history

  2. refactor: apply code review suggestions

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    154d3f3 View commit details
    Browse the repository at this point in the history

  3. refactor: remove focus restoration logic for now

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    11d5e11 View commit details
    Browse the repository at this point in the history

  4. test: add more tests to the manual trigger suite

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    60d5c29 View commit details
    Browse the repository at this point in the history

  5. refactor: use camel case in focus event listeners

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    92ca781 View commit details
    Browse the repository at this point in the history

  6. refactor: change __isManual to be a getter

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    a13bc8f View commit details
    Browse the repository at this point in the history

  7. test: remove unused test helpers

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    65250b9 View commit details
    Browse the repository at this point in the history

  8. fix: prevent closing immediately when using click + focus

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2d2ec6d View commit details
    Browse the repository at this point in the history

  9. fix: prevent immediate closing on click with focus trigger

    @web-padawan
    web-padawan committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f94af4f View commit details
    Browse the repository at this point in the history