Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add note about em unit in the column width jsdoc #7443

Merged
merged 2 commits into from
May 24, 2024
Merged

docs: add note about em unit in the column width jsdoc #7443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
460b923
docs: add note about `em` unit in the column `width` jsdoc
DiegoCardoso May 24, 2024
047322f
docs: add mention to the type declaration
DiegoCardoso May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/grid/src/vaadin-grid-column-mixin.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ export declare class GridColumnMixinClass<
> extends ColumnBaseMixinClass<TItem, Column> {
/**
* Width of the cells for this column.
*
* Please note that using the `em` length unit is discouraged as
* it might lead to misalignment issues if the header, body, and footer
* cells have different font sizes. Instead, use `rem` if you need
* a length unit relative to the font size.
*/
width: string | null | undefined;

Expand Down
5 changes: 5 additions & 0 deletions packages/grid/src/vaadin-grid-column-mixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,11 @@ export const GridColumnMixin = (superClass) =>
return {
/**
* Width of the cells for this column.
*
* Please note that using the `em` length unit is discouraged as
* it might lead to misalignment issues if the header, body, and footer
* cells have different font sizes. Instead, use `rem` if you need
* a length unit relative to the font size.
vursen marked this conversation as resolved.
Show resolved Hide resolved
*/
width: {
type: String,
Expand Down
Loading