fix: do not cancel edit column cell click events

[tomivirkki]

Description

Update vaadin-grid-pro-inline-editing-mixin.js to not cancel click events that occur in edit column cells. Canceling the click events blocks the grid connector from dispatching item-click events which in turn results in the Flow Grid item click listeners not getting invoked.

Related to #637

Type of change

Bugfix

[tomivirkki]

The changes to this file are just refactoring: the checks that were previously done inside the _onClick listener were moved to a new protected method _shouldPreventCellActivationOnClick .

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[vaadin-bot]

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick f30bd33
error: could not apply f30bd33... fix: do not cancel edit column cell click events (#7453)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick f30bd33
error: could not apply f30bd33... fix: do not cancel edit column cell click events (#7453)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.