fix: hide overlay if position target element is hidden (#7454) (CP: 23.5) #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: hide overlay if position target element is hidden If the target element is hidden, either by having `display: none` set to itself of any of its parents, a resize observer for that element is triggered. This change adds a check for the target element size on the resize observer callback and closes the overlay in case the element is hidden. Fixes #7437
DiegoCardoso
approved these changes
May 28, 2024
web-padawan
reviewed
May 28, 2024
|
packages/combo-box/test/fixtures/mock-combo-box-light-template-wrapper.js
Show resolved
Hide resolved
web-padawan
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.