New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide overlay if position target element is hidden (#7454) (CP: 24.4) #7456

Merged

DiegoCardoso merged 1 commit into 24.4 from cherry-pick-7454-to-24.4-1716892612272

May 28, 2024

Collaborator

vaadin-bot commented May 28, 2024

No description provided.


          fix: hide overlay if position target element is hidden (#7454)

d8ccf23

* fix: hide overlay if position target element is hidden

If the target element is hidden, either by having `display: none` set to
itself of any of its parents, a resize observer for that element is
triggered.

This change adds a check for the target element size on the resize
observer callback and closes the overlay in case the element is hidden.

Fixes #7437

sonarcloud bot commented May 28, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

web-padawan approved these changes

View reviewed changes

DiegoCardoso merged commit dc6c6a7 into 24.4

9 checks passed

DiegoCardoso deleted the cherry-pick-7454-to-24.4-1716892612272 branch

May 28, 2024 10:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet