Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add closed event when Notification is closed #7473

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

DiegoCardoso
Copy link
Contributor

Description

Add a new closed event that is triggered after the notification is closed

Part of #7422

Type of change

  • Bugfix
  • Feature

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding @fires JSDoc annotation and also typings tests for the new event.

@DiegoCardoso
Copy link
Contributor Author

Consider adding @fires JSDoc annotation and also typings tests for the new event.

Done.

Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DiegoCardoso DiegoCardoso merged commit c1f3c87 into main Jun 4, 2024
9 checks passed
@DiegoCardoso DiegoCardoso deleted the feat/notification/closed-event branch June 4, 2024 13:27
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants