feat: add no-vertical-overlap prop to vaadin-select #7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a property to `vaadin-select` called `noVerticalOverlap` which forwards its value to the same property present in the Overlay, to allow users to configure whether they want the overlay to overlap the input container (default) or not. Part of #5101
There was a problem hiding this comment.
One small thing I noticed is that for combo box, date picker, time picker there's a few pixels of offset between the input and the overlay. With select there is no offset between the value button and the overlay.
There was a problem hiding this comment.
Good catch. I had it done locally but forgot to commit the file 🤦🏻
sissbruecker
approved these changes
Jun 18, 2024
tomivirkki
approved these changes
Jun 19, 2024
|
2 tasks
|
This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a property to
vaadin-selectcallednoVerticalOverlapwhich forwards its value to the same property present in the Overlay, to allow users to configure whether they want the overlay to overlap the input container (default) or not.Part of #5101
Type of change