Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blur active element on step buttons touchend #7512

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7494

Adapted the code from #7494 (comment). One notable change is using getDeepActiveElement() helper instead of document.activeElement to ensure field's own <input> doesn't get blurred when the field is in shadow root.

Type of change

  • Bugfix

Copy link
Contributor

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jul 5, 2024

@web-padawan web-padawan merged commit dc75665 into main Jul 5, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/step-buttons-touch-blur branch July 5, 2024 09:19
sissbruecker pushed a commit that referenced this pull request Jul 5, 2024
sissbruecker pushed a commit that referenced this pull request Jul 5, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touchdevice: NumberField focus stays when step buttons of another field is pressed
4 participants