Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select date on Today click if today is max date #7516

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7505

Updated the logic to use "today midnight" for comparing with max. Without this change, the actual time is used and dateAllowed returns false when clicking "Today" button, thus making selecting today in this case impossible.

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Jul 5, 2024

@sissbruecker sissbruecker merged commit 703939b into main Jul 8, 2024
9 checks passed
@sissbruecker sissbruecker deleted the fix/today-max-date branch July 8, 2024 08:31
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @sissbruecker, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 703939b
error: could not apply 703939b... fix: select date on Today click if today is max date (#7516)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[date-picker] today button does not work if max is today
3 participants