Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only close combo-box overlay on blur from keyboard #7554

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Jul 16, 2024

Description

Fixes #7552

Changed the blur logic of vaadin-combo-box to only close when losing focus from keyboard, or if the opened is set to true but the overlay is not actually open (which is the case if no dropdown items match the filter).

This way we make sure that closing an opened combo-box happens on outside click (vs focusout) and therefore avoid closing of the parent vaadin-dialog (or vaadin-popover) - this is covered by new test in integration folder.

Also updated vaadin-time-picker to remove unnecessary value commit from focusout - in fact it was triggered twice in this case: first from focusout and then from combo-box change event. Now only the latter is used.

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Jul 16, 2024

@web-padawan web-padawan merged commit fab9459 into main Jul 17, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/combo-blur-close branch July 17, 2024 10:15
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick fab9459
error: could not apply fab9459... fix: only close combo-box overlay on blur from keyboard (#7554)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[popover] Combo-box overlay outside click closes parent popover
3 participants