-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: only close combo-box overlay on blur from keyboard #7554
Conversation
609e1e3
to
221fe4d
Compare
Quality Gate passedIssues Measures |
Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually? |
Co-authored-by: Serhii Kulykov <[email protected]>
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
Description
Fixes #7552
Changed the blur logic of
vaadin-combo-box
to only close when losing focus from keyboard, or if theopened
is set totrue
but the overlay is not actually open (which is the case if no dropdown items match the filter).This way we make sure that closing an opened combo-box happens on outside click (vs
focusout
) and therefore avoid closing of the parentvaadin-dialog
(orvaadin-popover
) - this is covered by new test inintegration
folder.Also updated
vaadin-time-picker
to remove unnecessary value commit fromfocusout
- in fact it was triggered twice in this case: first fromfocusout
and then from combo-boxchange
event. Now only the latter is used.Type of change