fix: allow focusing date-picker input using keyboard on fullscreen #7577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
web-padawan
force-pushed
the
fix/date-picker-fullscreen-focus
branch
from
dc22053
to
278d07d
Compare
web-padawan
force-pushed
the
fix/date-picker-fullscreen-focus
branch
from
278d07d
to
7c8ef66
Compare
web-padawan
force-pushed
the
fix/date-picker-fullscreen-focus
branch
from
7c8ef66
to
cf6f1ee
Compare
|
tomivirkki
approved these changes
Jul 24, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
web-padawan
added a commit
that referenced
this pull request
Jul 24, 2024
…7577) (#7581) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Jul 24, 2024
…7577) (#7580) Co-authored-by: Serhii Kulykov <[email protected]>
FrediWa
pushed a commit
that referenced
this pull request
Jul 24, 2024
FrediWa
pushed a commit
that referenced
this pull request
Jul 26, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha6 and is also targeting the upcoming stable 24.5.0 version. |
This was referenced Aug 29, 2024
This was referenced Aug 29, 2024
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#4809
Updated the date-picker logic to allow focusing with keyboard when
_noInputflag is set due to fullscreen mdoe.This way we make it possible to focus the date-picker on narrow screens or when applying zoom.
Can be tested e.g. by resizing a browser width to 600px and zooming to 150% (so that width changes to 400px).
Type of change