Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parts to drag source row cells #7593

Merged
merged 10 commits into from
Jul 30, 2024
Merged

feat: add parts to drag source row cells #7593

merged 10 commits into from
Jul 30, 2024

Conversation

FrediWa
Copy link
Contributor

@FrediWa FrediWa commented Jul 26, 2024

Description

Adds part attributes to the cells that are to be dragged. The image that follows the cursor around is left unchanged, it can be styled using the existing dragstart-row-cell part.

Styling the row itself cause issues, which is why it was intentionally left out.

Fixes #5548

Type of change

  • Feature

Checklist

  • I have performed self-review and corrected misspellings.

@FrediWa FrediWa marked this pull request as ready for review July 29, 2024 07:15
@FrediWa FrediWa requested a review from tomivirkki July 29, 2024 07:15
packages/grid/src/vaadin-grid.js Outdated Show resolved Hide resolved
packages/grid/src/vaadin-grid-drag-and-drop-mixin.js Outdated Show resolved Hide resolved
packages/grid/test/drag-and-drop.common.js Outdated Show resolved Hide resolved
@FrediWa FrediWa requested a review from tomivirkki July 30, 2024 05:41
packages/grid/src/vaadin-grid.js Outdated Show resolved Hide resolved
packages/grid/test/drag-and-drop.common.js Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 30, 2024

@FrediWa FrediWa merged commit 5e07d0b into main Jul 30, 2024
9 checks passed
@FrediWa FrediWa deleted the feat/drag-source-part branch July 30, 2024 10:06
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha7 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow developers to style the dragged item/row
3 participants