Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset title, subtitle and type when removing attribute #7816

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7768

Removed checks for title, subtitle and type property length to allow setting null (which is also the case when removing attribute) and added tests to ensure corresponding elements are correctly updated.

Type of change

  • Bugfix

Copy link

sonarcloud bot commented Sep 18, 2024

@web-padawan web-padawan removed the request for review from vursen September 18, 2024 17:29
@web-padawan web-padawan merged commit d930b7c into main Sep 18, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/charts-remove-attribute branch September 18, 2024 17:29
web-padawan added a commit that referenced this pull request Sep 18, 2024
web-padawan added a commit that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<vaadin-chart> is not updated when an attribute is removed
3 participants