feat: restore focus on dashboard widget removal #7860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
feat/dashboard-remove-focused
branch
from
4fc08cc
to
b1b174f
Compare
|
ugur-vaadin
reviewed
Sep 26, 2024
| @@ -165,7 +165,8 @@ export function expectLayout(dashboard: HTMLElement, layout: Array<Array<number | |||
| if (!element) { | |||
| actualRow.push(null); | |||
| } else { | |||
| actualRow.push(parseInt(element.id.replace('item-', ''))); | |||
| // TODO: Just use a number for all test item IDs | |||
There was a problem hiding this comment.
Should we add this to an improvements list or create an issue for this?
There was a problem hiding this comment.
It's a small chore, shouldn't need an issue
ugur-vaadin
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the dashboard widget including focus gets removed (for any reason), restore the focus to the widget closest to the removed one.
Kapture.2024-09-25.at.09.42.43.mp4
Type of change
Feature