refactor: remove no longer needed internal-tab event workaround #7870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
Sep 26, 2024
vursen
reviewed
Sep 26, 2024
vursen
approved these changes
Sep 26, 2024
|
vursen
approved these changes
Sep 26, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
web-padawan
added a commit
that referenced
this pull request
Sep 26, 2024
… (#7872) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #7858
Based on the suggestion from #7858 (review) we no longer need logic for
internal-tabevent invaadin-grid-prosincevaadin-custom-fieldcomponent has it covered by its_shouldRemoveFocus()implementation.Removed that code and added
vaadin-custom-fieldto thevaadin-grid-prointegration test file.Also refactored that test to only create single column per test suite to make sure it fits into viewport.
Type of change