fix: prevent opening select on click or keydown when disabled #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
approved these changes
Sep 26, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
web-padawan
added a commit
that referenced
this pull request
Sep 26, 2024
…#7877) Co-authored-by: Serhii Kulykov <[email protected]>
web-padawan
added a commit
that referenced
this pull request
Sep 26, 2024
…#7876) Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7873
By setting
pointer-events: autoit is currently possible to makevaadin-selectflash opening on click since we don't check fordisabledproperty in click listener. After adding the check, I also noticed thatvaadin-select-value-buttonstill receives focus which also means the same problem can happen on pressing Enter so I updatedkeydownlistener too.Type of change
Note
I think it's weird that
focusedis set on the select and value button when settingpointer-events: autoon the host.Disabled component shouldn't receive focus in any case. I'll make a separate PR to address that problem.