Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply initially set custom field value to inputs #7882

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7871

Added logic to store the value property set initially and apply it to inputs after they are populated.

Also added integration tests to cover the case when inputs are not yet upgraded (only happens for Vaadin web components but works with native <input> elements, see the issue description).

Type of change

  • Bugfix

@web-padawan web-padawan force-pushed the fix/custom-field-value-attribute branch from 4726554 to 45877cb Compare September 30, 2024 10:01
@web-padawan web-padawan force-pushed the fix/custom-field-value-attribute branch from f011ee0 to b88a143 Compare September 30, 2024 10:20
Copy link

sonarcloud bot commented Sep 30, 2024

@web-padawan web-padawan merged commit 783abaa into main Sep 30, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/custom-field-value-attribute branch September 30, 2024 10:29
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 783abaa
error: could not apply 783abaa... fix: apply initially set custom field value to inputs (#7882)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[custom-field] Value property reset and not applied to inputs when set as attribute
3 participants