Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 13/STORE: new error codes for Extended HistoryResponse #42

Closed
wants to merge 1 commit into from

Conversation

NagyZoltanPeter
Copy link
Collaborator

This is a small adjustment on new error codes introduced for waku's store protocol response.
Change is introduced by waku-org/pm#66 implementation.

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologise for confusion with new and existing RFCs and different repos, but indeed we are replacing this RFC 13 with a new version of Store (v3) where we do not explicitly define the error codes (exactly because we expect the list to grow significantly and do not want to have to update the RFC every time). Store v3 spec however still only exists in a branch as we have been modifying it extensively during the POC implementation. However, I think we are close to merging it into waku.org/specs as a new spec (but not RFC).

TL;DR - we not need to update this spec as we're moving to Store v3: https://github.com/vacp2p/rfc/pull/665/files

@jimstir
Copy link
Collaborator

jimstir commented Jun 3, 2024

I apologise for confusion with new and existing RFCs and different repos, but indeed we are replacing this RFC 13 with a new version of Store (v3) where we do not explicitly define the error codes (exactly because we expect the list to grow significantly and do not want to have to update the RFC every time). Store v3 spec however still only exists in a branch as we have been modifying it extensively during the POC implementation. However, I think we are close to merging it into waku.org/specs as a new spec (but not RFC).

TL;DR - we not need to update this spec as we're moving to Store v3: https://github.com/vacp2p/rfc/pull/665/files

@NagyZoltanPeter I will close this pr, when Store v3 is ready it will live in waku/specs repo.

@jimstir jimstir closed this Jun 3, 2024
@NagyZoltanPeter
Copy link
Collaborator Author

I apologise for confusion with new and existing RFCs and different repos, but indeed we are replacing this RFC 13 with a new version of Store (v3) where we do not explicitly define the error codes (exactly because we expect the list to grow significantly and do not want to have to update the RFC every time). Store v3 spec however still only exists in a branch as we have been modifying it extensively during the POC implementation. However, I think we are close to merging it into waku.org/specs as a new spec (but not RFC).
TL;DR - we not need to update this spec as we're moving to Store v3: https://github.com/vacp2p/rfc/pull/665/files

@NagyZoltanPeter I will close this pr, when Store v3 is ready it will live in waku/specs repo.

Yes, its ok! Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants